Skip to content

Conversation

mpsalunggg
Copy link

@mpsalunggg mpsalunggg commented Sep 29, 2025

Closes #106

Problem

I found that the placeholder text overlaps with the search icon in the contact input field.
Additionally, the contact sidebar icons are inconsistent in their width and height.

  • Search Input
Screenshot 2025-09-29 at 14 55 28
  • Icon Contact Filter
Screenshot 2025-09-29 at 15 42 43

Solution

  • Changed w-fit to w-full in the search-input component to prevent the placeholder from overlapping with the search icon.
  • Removed fixed width and height attributes on the sidebar contact icons to ensure consistent sizing with the existing icons.

How To Test

  1. Navigate to the Contacts section.
  2. Verify that the search input placeholder no longer overlaps with the search icon.
  3. Check the contact sidebar icons to confirm that their width and height are now consistent with each other.

Additional Checks

Also, please make sure to read the [contributing guidelines](https://github.com/marmelab/atomic-crm#contributing).

@mpsalunggg mpsalunggg changed the title [CHORE] - adjust contact component search input, icon contact filter [CHORE] - adjust UI contact component search input, icon contact filter Sep 29, 2025
Copy link
Collaborator

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for offering to work on this!
The fix for the icons in the contact filters looks good, thanks!


return (
<div className="flex flex-grow relative mt-auto w-fit">
<div className="flex flex-grow relative mt-auto w-full">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably not the correct fix. If the container is wider, then the icon will end up outside of the input.

image

We should probably instead fix the width of the TextInput

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, when I run it locally and use w-full, it looks like this
image
The icon is not missing from the input 🤔

@mpsalunggg mpsalunggg requested a review from slax57 September 29, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Revamp: Contact Sidebar with Search Input, Icon Contact Filter list
2 participants