-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
[Chore]: Update react-admin to use ReactNode instead of ReactElement where applicable #10996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although this is obviously the correct thing to do, I wonder if we should release this at least in a minor version. @slax57, @fzaninotto thoughts?
I tend to agree we should put this in a minor version. |
Worth mentionning that the enterprise edition compiles without any changes with this branch |
66a5156 to
7b12a15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the <InfiniteList> props also mention title and is incorrect (only mention string)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
Problem
A lot of RA components expect a
ReactElementwhere aReactNodecould be used.Solution
Replace
ReactElementwithReactNodewhere applicable.How To Test
N/A
Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a featureAlso, please make sure to read the contributing guidelines.