Skip to content

Conversation

@jonathanarnault
Copy link
Contributor

Problem

A lot of RA components expect a ReactElement where a ReactNode could be used.

Solution

Replace ReactElement with ReactNode where applicable.

How To Test

N/A

Additional Checks

  • The PR targets master for a bugfix or a documentation fix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

Also, please make sure to read the contributing guidelines.

@jonathanarnault jonathanarnault added the WIP Work In Progress label Oct 17, 2025
@jonathanarnault jonathanarnault changed the title WIP: [Chore]: Update ra-core to use ReactNode instead of ReactElement where applicable [Chore]: Update ra-core to use ReactNode instead of ReactElement where applicable Oct 20, 2025
@jonathanarnault jonathanarnault added RFR Ready For Review and removed WIP Work In Progress labels Oct 20, 2025
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this is obviously the correct thing to do, I wonder if we should release this at least in a minor version. @slax57, @fzaninotto thoughts?

@fzaninotto
Copy link
Member

Although this is obviously the correct thing to do, I wonder if we should release this at least in a minor version. @slax57, @fzaninotto thoughts?

I tend to agree we should put this in a minor version.

@djhi
Copy link
Collaborator

djhi commented Oct 22, 2025

Although this is obviously the correct thing to do, I wonder if we should release this at least in a minor version. @slax57, @fzaninotto thoughts?

I tend to agree we should put this in a minor version.

Worth mentionning that the enterprise edition compiles without any changes with this branch

@jonathanarnault jonathanarnault changed the title [Chore]: Update ra-core to use ReactNode instead of ReactElement where applicable [Chore]: Update react-admin to use ReactNode instead of ReactElement where applicable Oct 23, 2025
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the <InfiniteList> props also mention title and is incorrect (only mention string)

Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

@djhi djhi added this to the 5.13.0 milestone Oct 31, 2025
@djhi djhi merged commit 062221d into next Oct 31, 2025
15 checks passed
@djhi djhi deleted the chore/core-react-node branch October 31, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RFR Ready For Review

Development

Successfully merging this pull request may close these issues.

5 participants