Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

customising success message in delete with confirm #9868

Open
wants to merge 5 commits into
base: next
Choose a base branch
from
Open

customising success message in delete with confirm #9868

wants to merge 5 commits into from

Conversation

ethembynkr
Copy link

@ethembynkr ethembynkr commented May 22, 2024 •
edited by slax57
Loading

Closes #9837

@ethembynkr ethembynkr mentioned this pull request May 25, 2024
Open
@slax57
Copy link
Contributor

slax57 commented May 27, 2024

As is is a new feature, it needs to target the next branch. React Admin v4 is feature-freeze as we are in the verge of releasing React Admin v5. This feature will hence have to be released in v5.
Can you rebase onto next?

@ethembynkr ethembynkr changed the base branch from master to next May 27, 2024 12:01
@ethembynkr
Copy link
Author

Hi @slax57. I changed target branch to next. Can you review?

@fzaninotto
Copy link
Member

Thanks for your PR. Could you please add unit tests?

@ethembynkr
Added unit tests for successMessage in useDeleteWithConfirmController…
75d5616 
…, useDeleteWithConfirmController, BulkDeleteWithConfirmButton, BulkDeleteWithUndoButton, DeleteWithConfirmButton and DeleteWithUndoButton.
@ethembynkr
Copy link
Author

I've added unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Customising the message that appears after the delete operation in DeleteWithConfirmButton
3 participants
@ethembynkr @slax57 @fzaninotto