Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chrome-launcher doesn't support FreeBSD, and just calling
linux()
on FreeBSD would only work when the user setsCHROME_PATH
because the Chromium port on FreeBSD calls the binary "chrome" and not "google-chrome[-stable]" or "chromium[-stable]" like on Linux.So this PR adds a really simple function which looks for
CHROME_PATH
and also doeswhich chrome
when on FreeBSD.