Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable line number mapping. #32

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Disable line number mapping. #32

wants to merge 2 commits into from

Conversation

amcgregor
Copy link
Member

@amcgregor amcgregor commented Mar 15, 2024

Care of CEGID, my current employer, there are a collection of downstream changes utilized by the RITA job offer multi-posting platform. This pull request aims to homogenize the changes, eliminate the need to pin specific branches instead of released versions, and generally improve the project.

The mere presence of the generated line number mappings causes certain Python versions and configurations to fail to import the template module, generating an inscrutable error about unterminated values. This change eliminates the problem, but reduces debug–ability by removing the "origin line" mapping from each template module.

Corrects #30.

@amcgregor amcgregor self-assigned this Mar 15, 2024
@@ -59,7 +59,7 @@
"Topic :: Utilities",
],

packages = ['cinje'],
packages = find_packages(),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find_packages use has been deprecated? If this corrects the file ending issue that line number mapping triggers, there may be a larger issue?

Official documentation doesn't suggest using this function, which was an older Python 2 approach and theoretical way to "save time" back when it was most typical to have an executable setup.py script invoking setuptools. (See also: old-style namespaces which have a __init__.py files declaring the namespace. See this documentation for a complete description of "native namespace packages" v. "legacy namespace packages". That's also now just static project metadata.)

True, though, that packages should probably be: ['cinje', 'cinje.std', 'cinje.block', 'cinje.inline']

@amcgregor amcgregor linked an issue May 28, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Python 3.9
2 participants