Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/#2488 #3363

Closed
wants to merge 2 commits into from
Closed

Bugfix/#2488 #3363

wants to merge 2 commits into from

Conversation

Shaun2h
Copy link

@Shaun2h Shaun2h commented Oct 7, 2023

What do these changes do?

Implement suggested changes from @wjsi in #2488

Related issue number

Fixes #2488

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@Shaun2h Shaun2h requested a review from a team as a code owner October 7, 2023 14:59
@Shaun2h Shaun2h mentioned this pull request Oct 7, 2023
Open
@Shaun2h
Copy link
Author

Shaun2h commented Oct 8, 2023

Unsure on test requirements. Closing and fixing first.

@Shaun2h Shaun2h closed this Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] sort_values failed after using dropna
1 participant
@Shaun2h