fixed Unresolvable cycle detected #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was previously failing as follows because an array
has no "callbacks" property.
oauth2-server/lib/oauth2server.js:217
app.routes[method].callbacks.forEach(lockdownExpress3);
^
TypeError: Cannot call method 'forEach' of undefined
at OAuth2Server.lockdown (oauth2-server/lib/oauth2server.js:217:36)
Minor grammar error
Typo in Readme.md
Closes oauthjs#120 Closes oauthjs#124 Closes oauthjs#132
changed error handler res.send to fix express deprecation warnings
Update docs for model function getAccessToken
Fix lockdown pattern for array of routes in express 3
Preivously the extended grant function only had access the client credentials in the body, which could be different to the actual authenticated client. This fix exposes the authenticated credentials in req.oauth.client
- Currently supports password and refresh_token grants
URI as per RFC 3986 (http://tools.ietf.org/html/rfc3986#section-3)
…lient-creds-to-extended-grant Expose validated client for extended grant
…t-allow-any-uri Allow any valid URI for extension grants
…headers Set Cache-Control and Pragma Headers
Conflicts: Readme.md lib/error.js lib/grant.js lib/oauth2server.js package.json
|
👍 |
|
Please, merge :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.