-
Notifications
You must be signed in to change notification settings - Fork 6
WIP: Using DGL instead of Torch Geometric #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Fixing, disabling or removing tests, too
Clean up diff
Extra debug logging
| nearest = loss_fn.find_nearest_triangles(vertices, faces) | ||
| assert nearest.shape[0] == faces.shape[0] | ||
| assert nearest.shape[1] == 1 # k-1 = 1, since k=2 | ||
| assert nearest.shape[1] == k_val |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the comment from before does not fit anymore. The function will only return less than k if the number of centroids are less than k. Before we found the k nearest and remove self connections - DGL's function always returns k number of neighbours regardless of exclude self.
Co-authored-by: Martin Høst Normark <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.