Bugfix/fix sqlite holidays and excess data

python/README.md

@@ -1,6 +1,6 @@
 # Python version of Lift Pass Pricing Kata
 
-As with the other language versions, this exercise requires a database. There is a description in the [top level README](../README.md) of how to set up MySQL. If you don't have that, this version should fall back on sqlite3, and create a local database file 'lift_pass.db' in the directory where you run the application. Unfortunately the code doesn't actually work properly with sqlite3, so you'll have to adjust the SQL statements in prices.py.
+As with the other language versions, this exercise requires a database. There is a description in the [top level README](../README.md) of how to set up MySQL. If you don't have that, this version should fall back on sqlite3, and create a local database file 'lift_pass.db' in the directory where you run the application.
 
 For this python version you will also need to install the dependencies. I recommend you install them in a virtual environment like this:
 

python/src/db.py

@@ -20,6 +20,16 @@ def create_lift_pass_db_connection(connection_options):
 def try_to_connect_with_sqlite3(connection_options):
     import sqlite3
     connection = sqlite3.connect("lift_pass.db")
+    try:
+        connection.execute(
+            'SELECT * FROM holidays '
+            'WHERE holiday = 2019-03-04'
+        )
+    except sqlite3.OperationalError:
+        pass
+    else:
+        return connection
+
     create_statements = [
         """CREATE TABLE IF NOT EXISTS base_price (
             pass_id INTEGER PRIMARY KEY AUTOINCREMENT,
@@ -38,6 +48,7 @@ def try_to_connect_with_sqlite3(connection_options):
     ]
     for statement in create_statements:
         connection.execute(statement)
+        connection.commit()
 
     return connection
 

python/src/prices.py

@@ -46,6 +46,8 @@ def prices():
                     holiday = row[0]
                     if "date" in request.args:
                         d = datetime.fromisoformat(request.args["date"])
+                        if not isinstance(holiday, datetime):
+                            holiday = datetime.fromisoformat(holiday)
                         if d.year == holiday.year and d.month == holiday.month and holiday.day == d.day:
                             is_holiday = True
                 if not is_holiday and "date" in request.args and datetime.fromisoformat(request.args["date"]).weekday() == 0: