Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conventional install locations #98

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

AntoinePrv
Copy link

@AntoinePrv AntoinePrv commented Aug 1, 2023

  • CMake config files are typically installed under ${CMAKE_INSTALL_LIBDIR}/cmake/${PROJECT_NAME}, not the other way around;
  • LIBRARY DESTINATION and ARCHIVE_DESTINATION should default to CMAKE_INSTALL_LIBDIR (not CMAKE_INSTALL_LIBDIR/nanobench), which is the default when omited.
  • Add NANOBENCH_BUILD_TEST to control building of tests

@AntoinePrv
Copy link
Author

@martinus seeing build errors like the following, did this PR trigger them?

/tmp/cirrus-ci-build/src/test/unit_to_s.cpp:27:18: error: 'UINT64_C' was not declared in this scope
   27 |     REQUIRE(to_s(UINT64_C(123456789)) == "123456789");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant