-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add github CI #17
base: trunk
Are you sure you want to change the base?
Conversation
Adds a simple build workflow to github CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple notes I think should be looked into before merge, but otherwise LGTM :)
Co-authored-by: Hayden <[email protected]>
not too sure about the PR yet, partly not wanting to rely on GitHub for anything (this repository is really just a mirror that happens to accept issues and pull requests) I'd probably make the CI tests only do LTS to be honest, and use mise to do the runtime installation, that way it would always reflect the actual dev environment. |
you're likely to receive contributions over time, and that will be here on GitHub I imagine so any kind of CI setup will be beneficial if you want those contributions if you don't want contributions here, and would rather keep it wherever your "source" repo is, we can close this no problem |
I'm in agreement with @43081j -- if you'd rather your main point isn't GitHub, imo move everything to Codeberg, but GitHub is likely where you'll get the vast majority of contrib & such from, so it makes sense to use it. Plus, Github Actions isn't exactly GitHub-specific, you could move the setup & such to a different CI tool later on easily. |
Adds a simple build workflow to github CI.
This won't run the tests, only the build. until we add a root
test
script such that we can justpnpm test
in/
Currently, we can't do
pnpm run -r test
sincebun
is missing. So we would need to decide if to install bun globally or use node, etc.