Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add github CI #17

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

chore: add github CI #17

wants to merge 2 commits into from

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Dec 26, 2024

Adds a simple build workflow to github CI.

This won't run the tests, only the build. until we add a root test script such that we can just pnpm test in /

Currently, we can't do pnpm run -r test since bun is missing. So we would need to decide if to install bun globally or use node, etc.

Adds a simple build workflow to github CI.
Copy link

@hbjydev hbjydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple notes I think should be looked into before merge, but otherwise LGTM :)

.github/workflows/main.yml Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
@mary-ext
Copy link
Owner

mary-ext commented Dec 29, 2024

not too sure about the PR yet, partly not wanting to rely on GitHub for anything (this repository is really just a mirror that happens to accept issues and pull requests)

I'd probably make the CI tests only do LTS to be honest, and use mise to do the runtime installation, that way it would always reflect the actual dev environment.

@43081j
Copy link
Contributor Author

43081j commented Dec 29, 2024

you're likely to receive contributions over time, and that will be here on GitHub I imagine

so any kind of CI setup will be beneficial if you want those contributions

if you don't want contributions here, and would rather keep it wherever your "source" repo is, we can close this no problem

@hbjydev
Copy link

hbjydev commented Dec 29, 2024

I'm in agreement with @43081j -- if you'd rather your main point isn't GitHub, imo move everything to Codeberg, but GitHub is likely where you'll get the vast majority of contrib & such from, so it makes sense to use it. Plus, Github Actions isn't exactly GitHub-specific, you could move the setup & such to a different CI tool later on easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants