Suggestion for dynamic screen update #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CizBargah
commented
Oct 6, 2024
CizBargah
commented
- Use os.system('cls') to update
- Edit : Ignore __pycache/ in .gitignore
- Use os.system('cls') to update
Ignore __pycache/ in .gitignore
- On setup.py, optimize code, add pick_from_cards(cards, suggestion to rewrite set_up_decks), remove pick_from_cards(cards) On simulate.py, fix bug from incorrect difficulty, minor changes, suggestion to consider scenario where players tie On gameplay.py, minor changes
maryjess
reviewed
Oct 7, 2024
maryjess
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
LGTM, thanks @CizBargah !
Overall:
- new bug detected -- if the user enter incorrect difficulty for the second time, the code will continue to set up card with incorrect difficulty
- new issue -- end situation, what if tie condition?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.