Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgradle #147

Merged
merged 41 commits into from
Oct 27, 2024
Merged

Upgradle #147

merged 41 commits into from
Oct 27, 2024

Conversation

psibre
Copy link
Member

@psibre psibre commented Dec 8, 2022

No description provided.

@psibre psibre self-assigned this Dec 8, 2022
@psibre psibre changed the title Streamline Actions Upgradle Dec 11, 2022
@psibre
Copy link
Member Author

psibre commented Dec 18, 2022

We're seeing errors like

    Gradle suite > Gradle test > marytts.voice.CmuTimeAwb.LoadCmuTimeAwbIT > canGetProperty[0](name, cmu-time-awb) FAILED
        Assertion failed: 

        assert expected == actual
               |        |  |
               |        |  'en'
               |        false
               'cmu-time-awb'
            at org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:436)
            at org.codehaus.groovy.runtime.ScriptBytecodeAdapter.assertFailed(ScriptBytecodeAdapter.java:670)
            at marytts.voice.CmuTimeAwb.LoadCmuTimeAwbIT.canGetProperty(LoadCmuTimeAwbIT.groovy:76)

from the generated integration test.
This happens when multiple MaryConfigs are loaded simultaneously, and non-namespaced properties such as name clash from one MaryConfig to the next.

@psibre
Copy link
Member Author

psibre commented Jan 11, 2023

Processing errors under Java 17 isolated and resolved via marytts/marytts-voicebuilding#10

@psibre psibre marked this pull request as ready for review October 27, 2024 19:34
@psibre psibre merged commit 0249433 into marytts:master Oct 27, 2024
4 checks passed
@psibre psibre deleted the testing branch October 27, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant