Fixes for model creation #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The model creation code does not support Python 3:
Traceback (most recent call last):
File "/usr/lib/python3.4/runpy.py", line 170, in _run_module_as_main
"__main__", mod_spec)
File "/usr/lib/python3.4/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/home/p264360/git/depccg/build/src/py/lstm_parser_bi.py", line 340, in <module>
args.func(args)
File "/home/p264360/git/depccg/build/src/py/lstm_parser_bi.py", line 290, in <lambda>
if args.mode == "train"
File "/home/p264360/git/depccg/build/src/py/lstm_parser.py", line 126, in create_traindata
self._create_samples(trees)
File "/home/p264360/git/depccg/build/src/py/lstm_parser.py", line 111, in _create_samples
deps = self._get_dependencies(tree, len(tokens))
File "/home/p264360/git/depccg/build/src/py/lstm_parser.py", line 95, in _get_dependencies
assert len(filter(lambda i:i == 0, res)) == 1
TypeError: object of type 'filter' has no len()
Assumes the input (AUTO) files are UTF-8 encoded and UTF-8 encodes all output files in the model directory. Uses the codecs package for reading and writing files so that all str objects become unicode objects internally. This should also make future porting to Python 3 easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got the first part (model creation) to work for training data (AUTO files) that contain words with non-ASCII characters. I only had to change a few little things, hereby humbly submitted for consideration. ^^
Now to try the actual training…