Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removing mysql package, because mysql_native_password authenti… #2

Merged
merged 1 commit into from
May 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/bench.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@ jobs:
steps:
- name: MySQL - Verify mysqltest DB exists
run: mysql --host 0.0.0.0 --port 3306 -umysqltest -pmysqltest -e "SHOW DATABASES LIKE 'mysqltest'"
- name: MySQL - Using the old mysql_native_password to support mysql db connector
run: mysql --host 0.0.0.0 --port 3306 -uroot -e "ALTER USER 'mysqltest' IDENTIFIED WITH mysql_native_password BY 'mysqltest'; FLUSH PRIVILEGES"
- uses: actions/checkout@v4
with:
persist-credentials: true
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ jobs:
steps:
- name: MySQL - Verify mysqltest DB exists
run: mysql --host 0.0.0.0 --port 3306 -umysqltest -pmysqltest -e "SHOW DATABASES LIKE 'mysqltest'"
- name: MySQL - Using the old mysql_native_password to support mysql db connector
run: mysql --host 0.0.0.0 --port 3306 -uroot -e "ALTER USER 'mysqltest' IDENTIFIED WITH mysql_native_password BY 'mysqltest'; FLUSH PRIVILEGES"
- uses: actions/checkout@v4
with:
persist-credentials: true
Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ Object-Relational Mapping (ORM) is a powerful technique that allows you to inter
- [Kysely](./src/mysql/kysely.ts)
- [Mariadb](./src/mysql/mariadb.ts)
- [MikroORM](./src/mysql/mikro.ts)
- [MySQL](./src/mysql/mysql.ts)
- [MySQL2](./src/mysql/mysql2.ts)
- [Prisma](./src/mysql/prisma.ts)
- [Sequelize](./src/mysql/sequelize.ts)
Expand Down
Binary file modified bun.lockb
Binary file not shown.
2 changes: 0 additions & 2 deletions mysql.bench.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import {
mariadbGetUser,
mikroMySqlGetUser,
mySql2GetUser,
mySqlGetUser,
prismaMySqlGetUser,
sequelizeMySqlGetUser,
typeormMySqlGetUser,
Expand All @@ -19,7 +18,6 @@ group('MySQL', async () => {
bench('Kysely', async () => await getUser(kyselyMySqlGetUser));
bench('Mariadb', async () => await getUser(mariadbGetUser));
bench('MikroORM', async () => await getUser(mikroMySqlGetUser));
bench('MySQL', async () => await getUser(mySqlGetUser));
bench('MySQL2', async () => await getUser(mySql2GetUser));
bench('Prisma', async () => await getUser(prismaMySqlGetUser));
bench('Sequelize', async () => await getUser(sequelizeMySqlGetUser));
Expand Down
2 changes: 0 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"type": "module",
"devDependencies": {
"@pgtyped/cli": "^2.3.0",
"@types/mysql": "^2.15.26",
"@types/pg": "^8.11.5",
"@types/pg-pool": "^2.0.6",
"bun-types": "latest"
Expand All @@ -24,7 +23,6 @@
"kysely": "^0.27.3",
"mariadb": "^3.3.0",
"mitata": "^0.1.11",
"mysql": "^2.18.1",
"mysql2": "^3.9.7",
"pg": "^8.11.5",
"pg-pool": "^3.6.2",
Expand Down
6 changes: 0 additions & 6 deletions src/mysql/all.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import { prismaClose, prismaMySqlGetUser } from './prisma';
import { sequelizeClose, sequelizeMySqlGetUser } from './sequelize';
import { mikroClose, mikroMySqlGetUser } from './mikro';
import { typeormClose, typeormMySqlGetUser } from './typeorm';
import { mySqlClose, mySqlGetUser } from './mysql';

describe('[MySQL] unit tests', () => {
const checkUnit = async (fun: (id: number) => Promise<any>) => {
Expand Down Expand Up @@ -41,11 +40,6 @@ describe('[MySQL] unit tests', () => {
await mikroClose();
});

it('MySQL', async () => {
await checkUnit(mySqlGetUser);
mySqlClose();
});

it('MySQL2', async () => {
await checkUnit(mySql2GetUser);
await mySql2Close();
Expand Down
1 change: 0 additions & 1 deletion src/mysql/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ export * from './drizzle';
export * from './knex';
export * from './kysely';
export * from './mariadb';
export * from './mysql';
export * from './mysql2';
export * from './prisma';
export * from './sequelize';
Expand Down
29 changes: 0 additions & 29 deletions src/mysql/mysql.ts

This file was deleted.