Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: GameLayout, fix Tarot animation #146

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

refactor: GameLayout, fix Tarot animation #146

wants to merge 9 commits into from

Conversation

poiu694
Copy link
Member

@poiu694 poiu694 commented Sep 20, 2023

Issue Number

close: #

Description

구현 내용 및 작업한 내용

  • tarot과 normal에서 겹치는 부분을 GameLayout으로 묶었습니다.
  • TarotANimation에서 카드의 내용이 보여지고 leftSlide를 하지 않았던 오류를 수정했습니다.

To Reviewers

PR을 볼 때 주의깊게 봐야하거나 말하고 싶은 점

Checklist

PR 등록 전 확인한 것

  • PR 제목은 포맷과 내용 둘 다 알맞게 작성되었는가 (e.g., feat: 로그인 페이지 추가)
  • description에 PR에 대해 구체적으로 설명했는가

@poiu694 poiu694 self-assigned this Sep 20, 2023
swimjiy
swimjiy approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@swimjiy swimjiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확실히 묶어놓으니까 코드도 깔끔해져서 좋네! 고생 많았어요~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swimjiy swimjiy swimjiy approved these changes

@yungjurick yungjurick Awaiting requested review from yungjurick

Assignees

@poiu694 poiu694

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poiu694 @swimjiy