Upgrade Service Fabric to 5.6 #1
Open
+97
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set EventSource Name to ServiceFabric-FailBrick Renamed UnreliableServiceType.cs to FailBrick.cs to match class name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Matt, I've upgraded this to SF 5.6 and SF MSBuild 1.5.0, since it would not build on my machine (missing the SF MSBuild 1.1.0). The automatic upgrade failed in both VS 2015 and VS 2017, so I did it by hand. Please look it over and let me know if any adjustments are needed.
Separate from the pull request, I'm curious what the best way is to deploy this with different config to test it out. Is the process to modify the config, rev the config and deploy? Or is there an easier way through PowerShell or even the SF Cluster Manager? Ideally, I'd be interested in one of the easier options and I'm happy to contribute toward that end if it does not exist today. Thanks -John