Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openrpc generation tests in ci #623

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

thomas-senechal
Copy link
Member

No description provided.

@thomas-senechal thomas-senechal force-pushed the add-openrpc-generation-tests-in-ci branch 3 times, most recently from 676be17 to 554d295 Compare May 30, 2024 15:20
@thomas-senechal thomas-senechal force-pushed the add-openrpc-generation-tests-in-ci branch from a714a7e to 3f24485 Compare May 31, 2024 08:29
Copy link

sonarcloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@modship modship requested a review from Ben-Rey June 11, 2024 08:04
@@ -0,0 +1,207 @@
import {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file already exist in massa-web3 so we should not duplicate it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On "next" branch

@@ -0,0 +1,253 @@
import {
AddressFilter,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is also publicAPI.spec.ts in test/integration/publicAPI.spec.ts. Not sure it's exactly the same

@modship modship marked this pull request as draft June 19, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants