Fix for Thread.create issue with Haxe nightlies #188
Conversation
produces errors when pulling in munit as a lix dependecy in a project
src/massive/munit/TestRunner.hx
Outdated
| @@ -189,7 +189,11 @@ class TestRunner implements IAsyncDelegateObserver | |||
|
|
|||
| #if (neko || cpp || java || hl || eval) | |||
| var self = this; | |||
| var runThread:Thread = Thread.create(function() | |||
| var createThread = Thread.create; | |||
| #if (haxe4 && (haxe >= version("4.2.0-rc.1"))) | |||
There was a problem hiding this comment.
why not #if (haxe >= version("4.2.0-rc.1"))?
There was a problem hiding this comment.
mb?
var createThread = #if (haxe >= version("4.2.0-rc.1")) Thread.createWithEventLoop #else Thread.create #end;There was a problem hiding this comment.
I didn't want to break compatibility with Haxe 3, version("x.x.x") is a Haxe 4 feature
There was a problem hiding this comment.
that being said... I should have tested with Haxe 3, which makes a bit more ugly. I had to split the conditionals to make it work.
| var runThread:Thread = Thread.create(function() | ||
| var createThread = Thread.create; | ||
| #if haxe4 | ||
| #if (haxe >= version("4.2.0-rc.1")) |
There was a problem hiding this comment.
#if (haxe> = version (" 4.2.0-rc.1 ")) doesn't work without #if haxe4?
There was a problem hiding this comment.
it works fine on Haxe 4, but not on Haxe 3
There was a problem hiding this comment.
I didn't think it wouldn't compile, but I would still do one assignment instead of two))
|
looks good |
src/massive/munit/import.hx
Outdated
| package massive.munit; | ||
|
|
||
| #if haxe4 | ||
| #if (haxe >= version("4.1.0")) |
There was a problem hiding this comment.
maybe add tab?
#if haxe4
#if (...
#else
...
#end
#else
...
#endThere was a problem hiding this comment.
and
import Std.isOfType as isOfType;;)
No description provided.