add task solution #4641
Open
add task solution #4641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 28, 2024 23:12
DanilWeda
suggested changes
Mar 6, 2024
undeletable
reviewed
Mar 8, 2024
| alt="Moyo logo" | ||
| /> | ||
| </a> | ||
| <nav class="nav"> |
There was a problem hiding this comment.
Multiline sibling elements in HTML should have an empty line between them.
undeletable
reviewed
Mar 8, 2024
|
|
||
| .nav__link { | ||
| display: inline-block; | ||
| height: 60px; |
There was a problem hiding this comment.
You don't actually need both height and line-height in this case. One of them should be sufficient, just make sure that text is vertically centered.
There was a problem hiding this comment.
Hi! This is my way to make text centered and I have no idea how to do it another way in this case. Could you help?
There was a problem hiding this comment.
line-height sets the height of text line to 60px. So if there are no additional margins/paddings/borders etc., the element would be 60px high. This means that if you remove height style in this case, nothing would change.
undeletable
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
TEST REPORT LINK
Header height is set in 1 place (for the links)
Content is vertically centered (for any header height)
CSS is used to show all letters in Uppercase (don't type them in HTML)
Logo is an image wrapped with a link
CSS Variable is used for a blue color
Pseudo-element is used for a blue line below the active link
Code follows all the Code Style Rules ❗️