-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add moyo header #4689
base: master
Are you sure you want to change the base?
Add moyo header #4689
Conversation
create header
fix css file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine.
Add a hover effect to all navigation elements. (now only one navigation element has it )
You can create pull from any branch.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 As for your question - as I see it, yes, it should work
- On your code - please add the hover effect, as @DanilWeda mentioned
Per task:link color should be changed on :hover
But I added hover effect in the last commit, as |
Sorry, now everything might be ok
|
font-size: 12px; | ||
font-weight: 500; | ||
display: flex; | ||
text-transform: uppercase; | ||
list-style-type: none; | ||
margin: 0; | ||
padding: 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, order your css properties in a better way
.nav__link:hover { | ||
transition: 0.3s; | ||
color: var(--main-color); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move it closer to the .nav__link
selector
Unfortunally, I created pull request to the master branch in my account, and then merged these branches.
May I create new pull request to the master branch ma from my master?