Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #4729

Closed
wants to merge 3 commits into from
Closed

Develop #4729

wants to merge 3 commits into from

Conversation

luyx0
Copy link

@luyx0 luyx0 commented Mar 11, 2024

@luyx0 luyx0 closed this Mar 11, 2024
@luyx0 luyx0 reopened this Mar 11, 2024
src/style.css Outdated
.element::after {
content: '';
position: absolute;
background-color: #00acdc;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please define blue color as CSS variable

src/style.css Outdated Show resolved Hide resolved
src/style.css Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
Copy link

@undeletable undeletable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution looks fine, but needs improvements in order to meet guidelines and requirements. Please check the comments to the code.

@luyx0
Copy link
Author

luyx0 commented Mar 12, 2024

@luyx0 luyx0 closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants