Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add moyo #4731

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add moyo #4731

wants to merge 3 commits into from

Conversation

yanamomot
Copy link

@yanamomot yanamomot commented Mar 11, 2024

(Виправила) Не виконуються тести, але сторінка виглядає ідентичною

DEMO LINK
TEST REPORT LINK

[x]Header height is set in 1 place (for the links)
[x]Content is vertically centered (for any header height)
[x]CSS is used to show all letters in Uppercase (don't type them in HTML)
[x]Logo is an image wrapped with a link
[x]CSS Variable is used for a blue color
[x]Pseudo-element is used for a blue line below the active link
[x]Code follows all the Code Style Rules ❗️

Copy link

@alexander-ignatow alexander-ignatow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but some issues are needed to be fixed.

Please try fixing the tests

The deployed page lacks styles and images

image

src/index.html Outdated

<li class="nav__item">
<a
class="nav__link blue"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see class blue definition anywhere

Copy link

@alexander-ignatow alexander-ignatow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the comments!

Copy link

@DanilWeda DanilWeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.
Approved.
Thanks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants