Develop #4735
Open
Develop #4735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syogunok
commented
Mar 11, 2024
Syogunok
commented
- DEMO LINK
- TEST REPORT LINK
anastasiia-tilikina
suggested changes
Mar 11, 2024
src/style.css
Outdated
| } | ||
|
|
||
| nav { | ||
| display: block; |
There was a problem hiding this comment.
nav is display: block by default
src/index.html
Outdated
Comment on lines
28
to
56
| <header class="header"> | ||
| <a | ||
| href="#" | ||
| class="logo" | ||
| > | ||
| <img | ||
| src="images/logo.png" | ||
| alt="Moyo logo" | ||
| class="logo__image" | ||
| /> | ||
| </a> | ||
| <nav class="nav"> | ||
| <ul class="nav__list"> | ||
| <li class="nav__item"> | ||
| <a | ||
| href="#" | ||
| class="nav__link is-active" | ||
| > | ||
| Apple | ||
| </a> | ||
| </li> | ||
| <li class="nav__item"> | ||
| <a | ||
| href="#" | ||
| class="nav__link" | ||
| > | ||
| Samsung | ||
| </a> | ||
| </li> |
There was a problem hiding this comment.
Suggested change
| <header class="header"> | |
| <a | |
| href="#" | |
| class="logo" | |
| > | |
| <img | |
| src="images/logo.png" | |
| alt="Moyo logo" | |
| class="logo__image" | |
| /> | |
| </a> | |
| <nav class="nav"> | |
| <ul class="nav__list"> | |
| <li class="nav__item"> | |
| <a | |
| href="#" | |
| class="nav__link is-active" | |
| > | |
| Apple | |
| </a> | |
| </li> | |
| <li class="nav__item"> | |
| <a | |
| href="#" | |
| class="nav__link" | |
| > | |
| Samsung | |
| </a> | |
| </li> | |
| <header class="header"> | |
| <a | |
| href="#" | |
| class="logo" | |
| > | |
| <img | |
| src="images/logo.png" | |
| alt="Moyo logo" | |
| class="logo__image" | |
| /> | |
| </a> | |
| <nav class="nav"> | |
| <ul class="nav__list"> | |
| <li class="nav__item"> | |
| <a | |
| href="#" | |
| class="nav__link is-active" | |
| > | |
| Apple | |
| </a> | |
| </li> | |
| <li class="nav__item"> | |
| <a | |
| href="#" | |
| class="nav__link" | |
| > | |
| Samsung | |
| </a> | |
| </li> |
It is a good idea to add blank lines between multiline siblings. pls fix everywhere
etojeDenys
approved these changes
Mar 12, 2024
src/style.css
Outdated
Comment on lines
66
to
72
| .nav__link.is-active { | ||
| color: #00acdc; | ||
| } | ||
|
|
||
| .nav__link:hover { | ||
| color: #00acdc; | ||
| } |
There was a problem hiding this comment.
Suggested change
| .nav__link.is-active { | |
| color: #00acdc; | |
| } | |
| .nav__link:hover { | |
| color: #00acdc; | |
| } | |
| .nav__link.is-active, | |
| .nav__link:hover { | |
| color: #00acdc; | |
| } |
src/style.css
Outdated
| right: 0; | ||
| height: 4px; | ||
| border-radius: 2px; | ||
| background-color: #00acdc; |
There was a problem hiding this comment.
move this color to some var and reuse it everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.