-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #4931
base: master
Are you sure you want to change the base?
Develop #4931
Conversation
src/index.html
Outdated
<li class="nav__item"> | ||
<a | ||
href="#" | ||
class="nav__link apple is-active" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class="nav__link apple is-active" | |
class="nav__link is-active" |
src/style.css
Outdated
margin-left: 0; | ||
} | ||
|
||
a.is-active::after { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a.is-active::after { | |
.nav__link.is-active::after { |
style it by class
src/style.css
Outdated
color: #00acdc; | ||
} | ||
|
||
:hover { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:hover { | |
.nav__link:hover { |
} | ||
|
||
:hover { | ||
color: #00acdc; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this color to some var and reuse it everywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
я виправив помилки
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost done!
pls pay attention to the comments
} | ||
|
||
:hover { | ||
color: #00acdc; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not fixed!
src/index.html
Outdated
<header class="header"> | ||
<a | ||
href="index.html" | ||
class="logo" | ||
> | ||
<img | ||
src="images/logo.png" | ||
alt="Moyo_logo" | ||
class="logo__img" | ||
/> | ||
</a> | ||
<nav class="nav"> | ||
<ul class="nav__list"> | ||
<li class="nav__item"> | ||
<a | ||
href="#" | ||
class="nav__link is-active" | ||
> | ||
APPLE | ||
</a> | ||
</li> | ||
<li class="nav__item"> | ||
<a | ||
href="#" | ||
class="nav__link" | ||
> | ||
SAMSUNG | ||
</a> | ||
</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<header class="header"> | |
<a | |
href="index.html" | |
class="logo" | |
> | |
<img | |
src="images/logo.png" | |
alt="Moyo_logo" | |
class="logo__img" | |
/> | |
</a> | |
<nav class="nav"> | |
<ul class="nav__list"> | |
<li class="nav__item"> | |
<a | |
href="#" | |
class="nav__link is-active" | |
> | |
APPLE | |
</a> | |
</li> | |
<li class="nav__item"> | |
<a | |
href="#" | |
class="nav__link" | |
> | |
SAMSUNG | |
</a> | |
</li> | |
<header class="header"> | |
<a | |
href="index.html" | |
class="logo" | |
> | |
<img | |
src="images/logo.png" | |
alt="Moyo_logo" | |
class="logo__img" | |
/> | |
</a> | |
<nav class="nav"> | |
<ul class="nav__list"> | |
<li class="nav__item"> | |
<a | |
href="#" | |
class="nav__link is-active" | |
> | |
APPLE | |
</a> | |
</li> | |
<li class="nav__item"> | |
<a | |
href="#" | |
class="nav__link" | |
> | |
SAMSUNG | |
</a> | |
</li> |
pls fix everywhere
[x]
Header height is set in 1 place (for the links)
[x]
Content is vertically centered (for any header height)
[x]
CSS is used to show all letters in Uppercase (don't type them in HTML)
[x]
Logo is an image wrapped with a link
[x]
CSS Variable is used for a blue color
[x]
Pseudo-element is used for a blue line below the active link
[x]
Code follows all the [Code Style Rules ❗️]