develop #5604
develop #5604
Conversation
julia303920201
commented
Oct 27, 2024
julia303920201
commented
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Thank you for your hard work on this project! 😊 While you've made great progress, there are a few critical issues that need to be addressed before we can approve the pull request. The main concerns are related to the href attributes in your HTML file. These attributes are currently set to non-valid URLs or paths, which can significantly impact the navigation functionality of your webpage. Please update these to valid URLs or paths. Additionally, ensure that your CSS selectors match the classes defined in your HTML to avoid styling issues. Once these changes are made, your code will be in great shape! Keep up the good work, and don't hesitate to reach out if you need any help. 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
src/index.html
Outdated
| <header class="header"> | ||
| <a | ||
| class="logo" | ||
| href="dr" |
There was a problem hiding this comment.
The href attribute for the logo link is set to 'dr', which seems incorrect. It should be a valid URL or path. Consider updating it to the correct destination.
src/index.html
Outdated
| <li class="nav-item"> | ||
| <a | ||
| class="nav-link is-active" | ||
| href="Apple" |
There was a problem hiding this comment.
The href attribute for the 'Apple' link is set to 'Apple', which is not a valid URL. It should be a valid URL or path. Consider updating it to the correct destination.
src/index.html
Outdated
| <li class="nav-item"> | ||
| <a | ||
| class="nav-link" | ||
| href="Samsung" |
There was a problem hiding this comment.
The href attribute for the 'Samsung' link is set to 'Samsung', which is not a valid URL. It should be a valid URL or path. Consider updating it to the correct destination.
src/index.html
Outdated
| <li class="nav-item"> | ||
| <a | ||
| class="nav-link" | ||
| href="Smartphones" |
There was a problem hiding this comment.
The href attribute for the 'Smartphones' link is set to 'Smartphones', which is not a valid URL. It should be a valid URL or path. Consider updating it to the correct destination.
src/index.html
Outdated
| <a | ||
| class="nav-link" | ||
| data-qa="hover" | ||
| href="Laptops & Computers" |
There was a problem hiding this comment.
The href attribute for the 'Laptops & Computers' link is set to 'Laptops & Computers', which is not a valid URL. It should be a valid URL or path. Consider updating it to the correct destination.
src/index.html
Outdated
| <li class="nav-item"> | ||
| <a | ||
| class="nav-link" | ||
| href="Tablets" |
There was a problem hiding this comment.
The href attribute for the 'Tablets' link is set to 'Tablets', which is not a valid URL. It should be a valid URL or path. Consider updating it to the correct destination.
src/index.html
Outdated
| <li class="nav-item"> | ||
| <a | ||
| class="nav-link" | ||
| href="Photo" |
There was a problem hiding this comment.
The href attribute for the 'Photo' link is set to 'Photo', which is not a valid URL. It should be a valid URL or path. Consider updating it to the correct destination.
src/index.html
Outdated
| <li class="nav-item"> | ||
| <a | ||
| class="nav-link" | ||
| href="Video" |
There was a problem hiding this comment.
The href attribute for the 'Video' link is set to 'Video', which is not a valid URL. It should be a valid URL or path. Consider updating it to the correct destination.
| color: var(--active-color); | ||
| } | ||
|
|
||
| .nav__link:hover { |
There was a problem hiding this comment.
The selector .nav__link:hover seems to be incorrect as there is no class nav__link defined in the HTML. It should be .nav-link:hover to match the class used in the HTML file.
| border-radius: 8px; | ||
| } | ||
|
|
||
| :hover { |
There was a problem hiding this comment.
The :hover selector is too generic and will apply to all elements. Consider using a more specific selector to target only the elements you want to apply the hover effect to, such as .nav-link:hover.
