Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develop #5608

Closed
wants to merge 1 commit into from
Closed

develop #5608

wants to merge 1 commit into from

Conversation

andrii-petruk
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Thank you for your hard work on this project! 😊 While your code is mostly well-structured and meets many of the task requirements, there are a few critical issues that need to be addressed before we can approve the pull request:

  1. CSS Selector Usage: The use of the universal selector * can significantly impact performance. It's important to optimize your CSS for better efficiency.

  2. Flex Gap Property: The task specifies using margin instead of the gap property for indents. Please adjust your CSS to comply with this requirement.

  3. Image Alt Attribute: The alt attribute for images should be descriptive. Currently, it is set to "logo," which is not specific enough. This is important for accessibility.

  4. CSS Variable for Blue Color: Ensure that a CSS variable is used for the blue color as per the task requirements.

  5. Line Height: Avoid using uneven sizes like line-height: 14.6px. This can lead to inconsistent text rendering.

  6. HTML Formatting: Make sure your HTML formatting follows the checklist requirements, such as using 2 spaces for indentation.

Additionally, ensure that the parent element of .is-active has a suitable position property to support the position: absolute; of the pseudo-element, and address the URL encoding issue with the href attribute.

Once these issues are resolved, your code will be in great shape! Keep up the great work and don't hesitate to reach out if you have any questions. 🌟

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.


<li class="nav-item">
<a
href="/laptops&computers"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute value /laptops&computers might cause issues because the & character is not encoded. Consider using /laptops%26computers to ensure proper URL encoding.

width: 100%;
height: 4px;
background: var(--nav-link-hover-color);
position: absolute;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The position: absolute; property for the .is-active::after pseudo-element requires that the parent element has a position property set to relative, absolute, or fixed to ensure proper positioning. Ensure that the parent element of .is-active has a suitable position property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants