Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add solution #5613

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add solution #5613

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
808e33c
add solution
Vlad-2608 Oct 28, 2024
a6c347e
add solution
Vlad-2608 Oct 31, 2024
0cd31f9
add new color
Vlad-2608 Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ The page should match the design Pixel Perfect: all the sizes, colors and distan

❗️ Replace `<your_account>` with your Github username and copy the links to `Pull Request` description:

- [DEMO LINK](https://<your_account>.github.io/layout_moyo-header/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_moyo-header/report/html_report/)
- [DEMO LINK](https://Vlad-2608.github.io/layout_moyo-header/)
- [TEST REPORT LINK](https://Vlad-2608.github.io/layout_moyo-header/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

Expand Down
104 changes: 103 additions & 1 deletion src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,110 @@
rel="stylesheet"
href="./style.css"
/>

<link
rel="preconnect"
href="https://fonts.googleapis.com"
/>
<link
rel="preconnect"
href="https://fonts.gstatic.com"
/>
<link
href="https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,100;0,300;0,400;0,500;0,700;0,900;1,100;1,300;1,400;1,500;1,700;1,900&display=swap"
rel="stylesheet"
/>
</head>
<body>
<h1>Moyo header</h1>
<header class="header">
<a
href="#"
class="img"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a more descriptive href attribute for the anchor tag instead of #. This will improve accessibility and usability by providing a meaningful link destination.

>
<img
src="./images/logo.png"
alt="Logo"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the alt attribute for the image is descriptive enough to convey the purpose of the image to users who rely on screen readers. Currently, 'Logo' might not be sufficient if the logo represents a brand or company.

/>
</a>

<nav class="nav">
<ul class="nav__list">
<li class="nav__item">
<a
href="#"
class="nav__link is-active"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is set to #, which is not a valid destination. Consider providing a valid URL or a meaningful identifier for in-page navigation.

>
APPLE
</a>
</li>

<li class="nav__item">
<a
href="#"
class="nav__link"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to previous comments, ensure the href attribute points to a valid URL or meaningful identifier for better accessibility.

>
SAMSUNG
</a>
</li>

<li class="nav__item">
<a
href="#"
class="nav__link"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure the href attribute is set to a valid URL or meaningful identifier to improve navigation and accessibility.

>
SMARTPHONES
</a>
</li>

<li
class="nav__item"
data-qa="hover"
>
<a
href="#"
class="nav__link"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute should be updated to point to a valid URL or meaningful identifier for better navigation and accessibility.

>
LAPTOPS & COMPUTERS
</a>
</li>

<li class="nav__item">
<a
href="#"
class="nav__link"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider updating the href attribute to a valid URL or meaningful identifier for improved navigation and accessibility.

>
GADGETS
</a>
</li>

<li class="nav__item">
<a
href="#"
class="nav__link"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure the href attribute is set to a valid URL or meaningful identifier to enhance navigation and accessibility.

>
TABLETS
</a>
</li>

<li class="nav__item">
<a
href="#"
class="nav__link"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute should be updated to a valid URL or meaningful identifier for better navigation and accessibility.

>
PHOTO
</a>
</li>

<li class="nav__item">
<a
href="#"
class="nav__link"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider updating the href attribute to a valid URL or meaningful identifier to improve navigation and accessibility.

>
VIDEO
</a>
</li>
</ul>
</nav>
</header>
</body>
</html>
62 changes: 62 additions & 0 deletions src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,65 @@
body {
--color: #00acdc;

font-family: Roboto, serif;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a more specific font stack for better fallback options. For example, 'Roboto, Arial, sans-serif' would provide a more consistent appearance across different browsers and systems.

margin: 0;
padding: 0;
box-sizing: border-box;
}

.header {
width: 100%;
display: flex;
justify-content: space-between;
align-items: center;
}

.nav__link {
font-size: 12px;
text-decoration: none;
color: black;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a specific color like 'black' can be inflexible. Consider using a CSS variable or a more flexible color scheme to allow for easier theme changes in the future.

padding-top: 22px;
padding-bottom: 22px;
}

.nav__list {
list-style-type: none;
display: flex;
flex-wrap: nowrap;
}

.nav__item {
font-weight: 500;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The font-weight of 500 might not be supported by all fonts. Ensure that the 'Roboto' font includes this weight or consider using a more common weight like 400 or 600.

text-transform: uppercase;
margin-right: 20px;
}

.nav {
padding-right: 30px;
}

.img {
height: 40px;
width: 40px;
margin-top: 10px;
margin-left: 50px;
}

.is-active {
position: relative;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of 'position: relative;' on '.is-active' suggests that there might be positioned children. Ensure this is necessary for the intended design, as it can affect layout in unexpected ways.

}

.is-active::after {
position: absolute;
content: '';
left: 0;
width: 100%;
bottom: 0;
height: 4px;
background-color: var(--color);
border-radius: 10px;
}

.nav__link:hover {
color: var(--color);
}
Loading