add task solution #4820
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,130 @@ | ||
| $border-color: #f3f3f3; | ||
| $product-card-width: 200px; | ||
| $main-fonts: 'Roboto'; | ||
| $main-text-color: #060b35; | ||
| $second-text-color: #616070; | ||
| $button-color: #00acdc; | ||
| $border-radius: 5px; | ||
|
|
||
| body { | ||
| margin: 0; | ||
| } | ||
|
|
||
| .product-card { | ||
| display: flex; | ||
| flex-direction: column; | ||
| box-sizing: border-box; | ||
| width: $product-card-width; | ||
| border: 1px solid $border-color; | ||
| border-radius: $border-radius; | ||
| align-items: center; | ||
| justify-content: center; | ||
|
|
||
| &__image { | ||
| background-image: url('../images/imac.jpeg'); | ||
|
There was a problem hiding this comment. According to the checklist, images should be in the format of .png, .jpg, or .jpeg. The image 'imac.jpeg' should be checked to ensure it is in the correct format and renamed if necessary to adhere to the format guidelines. |
||
| background-repeat: no-repeat; | ||
| background-size: 100% 100%; | ||
| width: 160px; | ||
| height: 134px; | ||
| margin: 32px 19px 0; | ||
| box-sizing: border-box; | ||
| } | ||
|
Comment on lines
+23
to
+31
There was a problem hiding this comment. The BEM element '.product-card__image' has a margin with non-zero values, which is not recommended. BEM methodology suggests avoiding external geometry and positioning for BEM blocks and elements, such as margins. Consider refactoring this by utilizing the parent element to control the layout instead. |
||
|
|
||
| &__content { | ||
| margin: 40px 16px 16px; | ||
| font-family: $main-fonts, sans-serif; | ||
| } | ||
| } | ||
|
|
||
| .product-name { | ||
| font-weight: 500; | ||
| font-size: 12px; | ||
| line-height: 18px; | ||
| color: $main-text-color; | ||
| } | ||
|
|
||
| .product-code { | ||
| font-weight: 400; | ||
| font-size: 10px; | ||
| line-height: 14px; | ||
| color: $second-text-color; | ||
| margin: 4px 0 0; | ||
| } | ||
|
|
||
| .product-rating { | ||
| margin: 16px 0 0; | ||
| display: flex; | ||
| flex-direction: row; | ||
| justify-content: space-between; | ||
| align-items: flex-end; | ||
|
|
||
| &__reviews { | ||
| font-weight: 400; | ||
| font-size: 10px; | ||
| line-height: 14px; | ||
| color: $main-text-color; | ||
| } | ||
| } | ||
|
|
||
| .stars { | ||
| flex-direction: row; | ||
| display: flex; | ||
| gap: 4px; | ||
|
|
||
| &__star { | ||
| background-image: url('../images/star-active.svg'); | ||
| width: 16px; | ||
| height: 16px; | ||
| background-repeat: no-repeat; | ||
| background-position: center; | ||
|
|
||
| &:last-of-type { | ||
| background-image: url('../images/star.svg'); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| .product-price { | ||
| display: flex; | ||
| flex-direction: row; | ||
| justify-content: space-between; | ||
| margin: 24px 0 0; | ||
|
|
||
| &__text { | ||
| line-height: 18px; | ||
| font-weight: 400; | ||
| font-size: 12px; | ||
| color: $second-text-color; | ||
| } | ||
|
|
||
| &__value { | ||
| line-height: 18px; | ||
| font-weight: 700; | ||
| font-size: 16px; | ||
| color: $main-text-color; | ||
| } | ||
| } | ||
|
|
||
| .buy-button { | ||
| box-sizing: border-box; | ||
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| background-color: $button-color; | ||
| text-decoration: none; | ||
| color: #ffff; | ||
|
There was a problem hiding this comment. The color value should be written in lowercase to maintain consistency as per the code style rules. |
||
| font-weight: 700; | ||
| font-size: 14px; | ||
| line-height: 16px; | ||
| margin: 16px 0 0; | ||
| border-radius: $border-radius; | ||
| border: 1px solid $button-color; | ||
| width: 166px; | ||
| height: 40px; | ||
| text-transform: uppercase; | ||
|
|
||
| &:hover { | ||
| color: $button-color; | ||
| background-color: #ffff; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the checklist, text content should be wrapped in a paragraph
<p>tag, not a<div>. Consider changing<div class="product-name">to<p class="product-name">.