Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #4451

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add task solution #4451

wants to merge 1 commit into from

Conversation

Menwell
Copy link

@Menwell Menwell commented Aug 28, 2024

❗️ Copy this Checklist to the Pull Request description after links, and put - [x] before each point after you checked it.

  • Icon implemented using background-image CSS property
  • Inputs are written inside of 'form' tag with correctly passed attributes
  • All Typical Mistakes from BEM lesson theory are checked.
  • Code follows all the Code Style Rules ❗️

anastasiiavorobiova
anastasiiavorobiova suggested changes Aug 28, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Consider removing default outlines

@Menwell
Copy link
Author

Menwell commented Aug 28, 2024

Great work! Consider removing default outlines

are you talking about input fields? text-decoration: none ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anastasiiavorobiova anastasiiavorobiova anastasiiavorobiova requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Menwell @anastasiiavorobiova