Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #4461

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add task solution #4461

wants to merge 4 commits into from

Conversation

MrZefirchk
Copy link

@MrZefirchk MrZefirchk commented Sep 6, 2024 •
edited
Loading

  • DEMO LINK

  • TEST REPORT LINK

  • Icon implemented using background-image CSS property

  • Inputs are written inside of 'form' tag with correctly passed attributes

  • All Typical Mistakes from BEM lesson theory are checked.

  • Code follows all the Code Style Rules ❗️

anastasiiavorobiova
anastasiiavorobiova suggested changes Sep 6, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! Could you please deploy your solution and provide a link to the demo page in the PR description

anastasiiavorobiova
anastasiiavorobiova suggested changes Sep 6, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, the demo isn't reachable
Screenshot 2024-09-06 at 15 44 35

@MrZefirchk
Copy link
Author

Screenshot 2024-09-06 at 19 18 29

в мене deploy не працює

volodymyr-soltys97
volodymyr-soltys97 suggested changes Sep 6, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
To improve:

  1. Don't need to hide the search icon when input is focused, also, remove the default blue border
image

SanyaBratashchuk
SanyaBratashchuk suggested changes Sep 6, 2024
View reviewed changes
Copy link

@SanyaBratashchuk SanyaBratashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. icon still hidden in focus state
    image

@MrZefirchk
Copy link
Author

Screenshot 2024-09-06 at 20 55 04 в мене deploy не працює, тому там скоріше неправильно показує, через npm start все ок

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanyaBratashchuk SanyaBratashchuk SanyaBratashchuk approved these changes

@anastasiiavorobiova anastasiiavorobiova Awaiting requested review from anastasiiavorobiova

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MrZefirchk @volodymyr-soltys97 @SanyaBratashchuk @anastasiiavorobiova