Merge pull request #77 from matepek/development

chokidar related bug fix
matepek · Mar 18, 2019 · d229c21 · d229c21
2 parents 415671b + 1139244
commit d229c21
Show file tree

Hide file tree

Showing 5 changed files with 61 additions and 37 deletions.
diff --git a/.appveyor.yml b/.appveyor.yml
@@ -24,4 +24,3 @@ test_script:
 on_failure:
   - dir .\out\test
   - type .\out\test\FailedTestLogs\log_*.txt
-  #- type .\out\test\alltestlogs.txt
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [2.3.27]
+
+### Fixed
+
+- a bug related to abs-path watcher (`chokidar`).
+
 ## [2.3.26] - 2019-03-18
 
 ### Added

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -59,14 +59,14 @@
     "@types/entities": "^1.1.1",
     "@types/fs-extra": "^5.0.5",
     "@types/mocha": "^5.2.6",
-    "@types/node": "^10.12.30",
+    "@types/node": "^10.14.1",
     "@types/request-promise": "4.1.42",
     "@types/sinon": "^5.0.7",
     "@types/xml2js": "^0.4.3",
     "@typescript-eslint/eslint-plugin": "^1.4.2",
     "@typescript-eslint/parser": "^1.4.2",
     "deep-equal": "^1.0.1",
-    "eslint": "^5.15.1",
+    "eslint": "^5.15.2",
     "eslint-config-prettier": "^4.1.0",
     "eslint-plugin-prettier": "^3.0.1",
     "fs-extra": "^7.0.1",

diff --git a/src/TestExecutableInfo.ts b/src/TestExecutableInfo.ts
@@ -101,6 +101,13 @@ export class TestExecutableInfo implements vscode.Disposable {
           ignorePermissionErrors: true,
         });
 
+        this._absWatcherReady = new Promise(resolve => {
+          this._absWatcher!.once('ready', resolve);
+        });
+
+        // getWatched works after the ready event
+        await this._absWatcherReady;
+
         this._absWatcher.on('all', (event: string, filePath: string) => {
           this._shared.log.info('absWacher all event:', event, filePath);
           this._handleEverything(vscode.Uri.file(filePath));
@@ -110,13 +117,6 @@ export class TestExecutableInfo implements vscode.Disposable {
           this._shared.log.error('absWacher error:', args);
         });
 
-        this._absWatcherReady = new Promise(resolve => {
-          this._absWatcher!.once('ready', resolve);
-        });
-
-        // getWatched works after the ready event
-        await this._absWatcherReady;
-
         const watched = this._absWatcher.getWatched();
 
         for (const dir in watched) {