filter suite duplication

CHANGELOG.md

@@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - a bug which caused that `files.exlude` were also applied to pattern. Not anymore.
 - a bug which caused to show not file names but patterns in the explorer.
+- a bug which allowed suite duplications if more patterns were matching.
 
 ## [2.3.8] - 2019-01-03
 

package.json

@@ -5,7 +5,7 @@
   "icon": "resources/icon.png",
   "author": "Mate Pek",
   "publisher": "matepek",
-  "version": "2.3.8",
+  "version": "2.3.9",
   "license": "Unlicense",
   "homepage": "https://github.com/matepek/vscode-catch2-test-adapter",
   "repository": {

src/RootTestSuiteInfo.ts

@@ -112,6 +112,11 @@ export class RootTestSuiteInfo implements TestSuiteInfo, vscode.Disposable {
   insertChild(suite: TestSuiteInfoBase): boolean {
     if (this.children.indexOf(suite) != -1) return false;
 
+    // we want to filter the situation when 2 patterns match the same file
+    if (this.children.find((s: TestSuiteInfoBase) => { return suite.execPath == s.execPath; })) {
+      return false;
+    }
+
     let i = this.children.findIndex((v: TestSuiteInfoBase) => {
       return suite.label.trim().localeCompare(v.label.trim()) < 0;
     });

src/TestExecutableInfo.ts

@@ -87,8 +87,9 @@ export class TestExecutableInfo implements vscode.Disposable {
       const file = fileUris[i];
       await this._createSuiteByUri(file).then((suite: TestSuiteInfoBase) => {
         return suite.reloadChildren().then(() => {
-          this._executables.set(file.fsPath, suite);
-          this._allTests.insertChild(suite);
+          if (this._allTests.insertChild(suite)) {
+            this._executables.set(file.fsPath, suite);
+          }
         }, (reason: any) => {
           this._allTests.log.error('Couldn\'t load executable: ' + inspect([reason, suite]));
         });