Skip to content

fix(Autocomplete) refactored options data to set on autocomplete object #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2025
Merged

fix(Autocomplete) refactored options data to set on autocomplete object #638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions components/search/autocomplete.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ const _defaults: AutocompleteOptions = {
onSearch: (text: string, autocomplete: Autocomplete) => {
const normSearch = text.toLocaleLowerCase();
autocomplete.setMenuItems(
autocomplete.options.data.filter(
autocomplete.data.filter(
(option) =>
option.id.toString().toLocaleLowerCase().includes(normSearch) ||
option.text?.toLocaleLowerCase().includes(normSearch)
Expand All @@ -95,7 +95,7 @@ const _defaults: AutocompleteOptions = {
},
maxDropDownHeight: '300px',
allowUnsafeHTML: false,
selected: []
selected: [],
};

export class Autocomplete extends Component<AutocompleteOptions> {
Expand All @@ -115,6 +115,7 @@ export class Autocomplete extends Component<AutocompleteOptions> {
static _keydown: boolean;
selectedValues: AutocompleteData[];
menuItems: AutocompleteData[];
data: AutocompleteData[];

constructor(el: HTMLInputElement, options: Partial<AutocompleteOptions>) {
super(el, options, Autocomplete);
Expand All @@ -131,9 +132,10 @@ export class Autocomplete extends Component<AutocompleteOptions> {
this.oldVal = '';
this.selectedValues =
this.selectedValues ||
this.options.selected.map((value) => <AutocompleteData>{ id: value }) ||
this.options.selected.map((value: number | string) => <AutocompleteData>{ id: value }) ||
[];
this.menuItems = this.options.data || [];
this.data = this.options.data || [];
this.$active = null;
this._mousedown = false;
this._setupDropdown();
Expand Down Expand Up @@ -535,23 +537,26 @@ export class Autocomplete extends Component<AutocompleteOptions> {
* @param menuItems Items to be available.
* @param selected Selected item ids
* @param open Option to conditionally open dropdown
* @param initial Condition to set initial data
*/
setMenuItems(
menuItems: AutocompleteData[],
selected: number[] | string[] = null,
open: boolean = true
open: boolean = true,
initial: boolean = false,
) {
this.menuItems = menuItems;
this.options.data = menuItems;
if (initial) {
this.data = menuItems;
}
if (selected) {
this.selectedValues = this.menuItems.filter(
(item) => !(selected.indexOf(<never>item.id) === -1)
);
}
if (this.options.isMultiSelect) {
this._renderDropdown();
} else {
this._refreshInputText();
}
if (open) this.open();
this._updateSelectedInfo();
Expand Down