Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use blueprint for lpad gui #472

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

use blueprint for lpad gui #472

wants to merge 23 commits into from

Conversation

tschaume
Copy link
Member

@tschaume tschaume commented Jan 5, 2022

Converting lauchpad GUI to a Flask Blueprint to allow for it to be mounted at a different prefix/application root @mkhorton @shreddd

tschaume and others added 23 commits August 2, 2018 21:56
@tschaume
flask_site blueprint
ce99b68
@tschaume
run flask_site in JupyterHub
77694b6
@tschaume
Merge remote-tracking branch 'origin/master' into tschaume_master
bc04755
@tschaume
filter benign numpy warnings
9037b3c
@tschaume
Merge remote-tracking branch 'upstream/master'
b376f36
@shreddd
set application_root
c2662c4
@shreddd
set generic app root config
e499b57
@tschaume
Merge remote-tracking branch 'upstream/master'
8e00ca6
@shreddd
Merge remote-tracking branch 'tschaume/master'
49d56c4
@shreddd
fix url prefix
f5c6d05
@tschaume
webgui: add APPLICATION_ROOT
d6de64b
@shreddd
fix BP registration
b8a4bf0
@tschaume
Merge branch 'master' of https://github.com/shreddd/fireworks into sh…
69623d9 
…reddd-master
@tschaume
go back to gunicorn
4973c3b
@tschaume
Merge branch 'shreddd-master'
38ec95d
@tschaume
fix blueprint urls
5215d95
@tschaume
args check, fixes materialsproject#331
7a18c78
@tschaume
Merge branch 'master' into tschaume-master
39a1488
@tschaume
Merge branch 'master' of https://github.com/materialsproject/fireworks
148ad39
@tschaume
use simplejson
621e0f0
@tschaume
Merge branch 'master' of github.com:tschaume/fireworks
a1f6b6e
@tschaume
Merge remote-tracking branch 'upstream/main'
ec24ad8
@tschaume
whitespace fixes
0701e22
@mkhorton
Copy link
Member

mkhorton commented Jan 5, 2022

Thanks @tschaume. Can I confirm that, to your knowledge, there are no breaking changes in this PR?

@computron This PR is to allow us to more easily deploy FW dashboards for multiple people on NERSC infrastructure but should otherwise not affect dashboards for regular users.

@tschaume
Copy link
Member Author

tschaume commented Jan 5, 2022

@mkhorton There shouldn't be breaking changes but the commented-out part in fireworks/scripts/lpad_run.py needs to be tested.

@computron
Copy link
Member

@mkhorton @tschaume I'm trying to catch up on some PRs - could you let me know the current status of this? It looks like some tests are failing but maybe they just need a quick rerun or check

@computron computron added the stale Stale/abandoned PRs and issues label Feb 1, 2022
@tschaume
Copy link
Member Author

tschaume commented Feb 1, 2022

@shreddd and @mkhorton have used the blueprint successfully already I think. Based on what's in this PR, this part needs reimplementation to work with blueprints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale Stale/abandoned PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tschaume @mkhorton @computron @shreddd