Adapt to math-comp/math-comp#1237 #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi8027
commented
Jul 8, 2024
Comment on lines
+66
to
+69
| (* TODO: remove when dropping the support for MathComp 2.2 *) | ||
| Local Fact real_floor_itv (R : archiNumDomainType) (x : R) : | ||
| x \is Num.real -> (Num.floor x)%:~R <= x < (Num.floor x + 1)%:~R. | ||
| Proof. exact: real_floor_itv || exact: floor_itv. Qed. |
There was a problem hiding this comment.
@affeldt-aist Renaming in math-comp/math-comp#1235 had to be done with deprecation.
|
@proux01 Can you fix Nix CI here (the second commit) ? |
4 tasks
|
@proux01 @CohenCyril The change you suggested does not seem to fix Nix CI. Can you take a look? |
proux01
reviewed
Jul 10, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.