rename setD_closed to setSD_closed #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
affeldt-aist
added
the
renaming/refactoring 🔧
affeldt-aist
force-pushed
the
fixes_1225a
branch
from
509148b
to
1c8ef71
Compare
affeldt-aist
force-pushed
the
fixes_1225a
branch
from
67fcd6a
to
ff67d47
Compare
|
Since this renaming has been considered during the last meeting and nobody disagrees, I might merge by the end of the day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is a first step towards fixing the issue #1225 :
rename
setD_closedtosetSD_closedso thatsetDI_closedcan be renamedsetD_closedlater.Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Reminder to reviewers