Remove duplicated lemmas and dependency to Rstruct #1347
+10
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zstone1
reviewed
Oct 11, 2024
| @@ -3708,7 +3640,7 @@ exists (Uniform.class T'), ([set xy | ball (f xy.1) 1 (f xy.2)]); split. | |||
| Qed. | |||
|
|
|||
| Section normalP. | |||
| Context {T : topologicalType}. | |||
| Context {R : realType} {T : topologicalType}. | |||
|
|
|||
| Let normal_spaceP : [<-> | |||
There was a problem hiding this comment.
So the reason I didn't do this before is that none of the clauses in normal_spaceP actually depend on R. It's only used internally in the proofs. So if there's a preferred way to show that there is an instance of realType, that would be great. If not then I am ok with this change if removing the dependency is helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This both removes copy/pasted lemmas (the removed lemmas are still in Rstruct.v) and an undue dependency to Rstruct.
Checklist
[ ] added corresponding entries inCHANGELOG_UNRELEASED.md[ ] added corresponding documentation in the headersReference: How to document
Reminder to reviewers