Skip to content

Hahn banach 2026#1889

Draft
mkerjean wants to merge 28 commits intomath-comp:masterfrom
mkerjean:hahn_banach_2026
Draft

Hahn banach 2026#1889
mkerjean wants to merge 28 commits intomath-comp:masterfrom
mkerjean:hahn_banach_2026

Conversation

@mkerjean
Copy link
Copy Markdown
Collaborator

@mkerjean mkerjean commented Mar 6, 2026

Motivation for this change
Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@affeldt-aist affeldt-aist mentioned this pull request Mar 11, 2026
2 tasks
@affeldt-aist affeldt-aist added this to the 1.17.0 milestone Mar 12, 2026
@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Mar 12, 2026
@mkerjean mkerjean force-pushed the hahn_banach_2026 branch 2 times, most recently from c18bf37 to 323445b Compare March 13, 2026 11:35
@mkerjean mkerjean force-pushed the hahn_banach_2026 branch 2 times, most recently from 224e82e to 18f2a80 Compare March 31, 2026 12:46
@mkerjean mkerjean force-pushed the hahn_banach_2026 branch 2 times, most recently from 065e12f to 6344896 Compare April 3, 2026 03:21
@mkerjean mkerjean force-pushed the hahn_banach_2026 branch 2 times, most recently from 23fe018 to 50b1d73 Compare April 15, 2026 04:04
@affeldt-aist
Copy link
Copy Markdown
Member

I made a pass on the file: moving a few lemmas to mathcomp_extra.v and unstable.v, linting the code, creating a functional_analysis sub-directory, starting the changelog (NB: it contains a fix for the changelog in master which is buggy, my bad).

Since topU is defined at the top-level and therefore exposed, maybe a name like sub_initial_topology is better (btw, it should be documented).

TODO: move the new structures out of this file.

@affeldt-aist
Copy link
Copy Markdown
Member

Compilation is fine with MathComp 2.5.0 but it looks like with a problem with the duplication of the SubNormedZmodule in MathComp and MathComp-Analysis:

Error:
You must declare the hierarchy bottom-up or add a missing join. 
There are two ways out: 
- declare structure SubNormedZmodule before structure Num.SubNormedZmodule if Num.SubNormedZmodule inherits from it; 
- declare an additional structure that inherits from both Num.SemiNormedZmodule and SubType and from which SubNormedZmodule and/or Num.SubNormedZmodule inherit.

It this is really the case, is there a trick to make it compile with both versions? @CohenCyril @gares
(It could even be a feature of HB? Again, not sure whether my diagnosis is correct...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ✨ This issue/PR is about adding new features enhancing the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants