Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve HB.instance #421

Merged
merged 14 commits into from
Jun 17, 2024
Merged

improve HB.instance #421

merged 14 commits into from
Jun 17, 2024

Conversation

gares
Copy link
Member

@gares gares commented Jun 10, 2024

  • toposort using gref specific data structures
  • fast fail for sub-classes of a class that failed to be inferred

HB/instance.elpi Outdated Show resolved Hide resolved
@CohenCyril
Copy link
Member

The real bench is mca, I just added it, and I'm running it on my computer this afternoon (MCA takes about 20min if I recall correctly)

@gares gares marked this pull request as ready for review June 13, 2024 08:02
HB/common/stdpp.elpi Outdated Show resolved Hide resolved
@proux01
Copy link
Contributor

proux01 commented Jun 17, 2024

@CohenCyril coq-community/coq-nix-toolbox#224 merged, could you please update the toolbox and rerun CI here

@proux01
Copy link
Contributor

proux01 commented Jun 17, 2024

CI green, this looks good to be (squashed and) merged

@gares gares merged commit 85e0c61 into master Jun 17, 2024
146 of 151 checks passed
@gares
Copy link
Member Author

gares commented Jun 17, 2024

I still don't get why XS and elements {make-set XS} make any difference for ssrnum, but I guess I'll have to live with that.

There was a hack in ssrnum, maybe @CohenCyril recalls it? I don't think it should impact here though.

@proux01
Copy link
Contributor

proux01 commented Jun 17, 2024

The failure was about SemiGroup and Monoids, didn't felt like related to the hack (but maybe remotely who knows).

@gares gares deleted the instance-perf branch June 18, 2024 11:10
@proux01
Copy link
Contributor

proux01 commented Jun 18, 2024

FTR

  • mathcomp
    • before: 15:21, 1708708 kb
    • after: 13:36, 1681224 kb (-11%, -2%)
  • analysis
    • before: 16:29, 1926688 kb
    • after: 13:56, 1808196 kb (-15%, -6%)

@gares
Copy link
Member Author

gares commented Jun 18, 2024

We could also try with the version of toposort by @Tragicus but we need elpi 1.19.2 for an efficient coq.gref.set.fold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants