Revert custom line-height on Dropdown

[seancolsen]

Fixes #4332

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the develop branch of the repository
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[seancolsen]

@pavish in #4332 you said:

I wanted the dropdown to have the same height as other input fields such as buttons and textbox

Cool, I like this goal.

I'm continuing the conversation here, now specifically within the context of the changes I'd like to make.

I'm confused by your comment though. Because your addition of line-height: 1 in Dropdown.scss seems to have made the heights less consistent, not more.

On /administration/users/1/ we have Input, Select, and Button components. I measured their height across three browsers at 100% and 200% zoom. Here is what I found (before this PR):

• Element heights (in px):

  Element	Firefox	Chrome	Safari
  Input	34 (33.5 @2x)	30.8	33
  Select	28	28	28
  Button	30.8	30.8	30 (31 @2x)

  @2x = when zoom = 200%

This PR makes Select use the same height as Button.

• In Chrome, all three heights become identical.

• Firefox and Safari are a little weirder because:

  • They appear to be using a minimum line-height for <input> elements, perhaps for the sake of a11y.
  • Page zoom seems to have some subtle effects that I don't fully understand.

  I got sucked into a rabbit hole researching the difference in line-height behavior for <input> elements across different browsers, but I think if we just go off of Chrome it'll simplify this discussion.

Even in FF and Chrome, this PR would bring the height of Select closer to the height of Input, which seems like a win. It still wouldn't be identical, but I don't want to spend time perfecting it right now when I'm ultimately just trying to solve the problem of clipped text.

Will this work for you, @pavish?

In #4332 you said:

we should make that change for all input elements.

I'm not seeing a need for other changes. From what I can tell, other input elements already have line-height of 1.2 (via inherit). If you could point out a specific problem that this PR creates, I'd be very curious to see!