-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error-tolerant mode #19
base: master
Are you sure you want to change the base?
Conversation
@mathiasbynens does that implementation comply with what you had in mind? Could you please review when you have time? |
Of course! It might take a while until I get around to it, though. |
No problem! Please tell me if I can help in any way. |
Hi @mathiasbynens ! Do you know when you'll be able to review that PR please? |
c373d19
to
41c4eef
Compare
4eff386
to
d4de352
Compare
@darrachequesne Does this handle the case of missing or extra continuation bytes? The encoding utf8.decode(
'\xE2\xAC\xE2\x82\xAC', // 11100010 10101100 11100010 10000010 10101100
{strict: false},
) === '\uFFFD\u20AC'; Likewise, utf8.decode(
'\xE2\x82\xAC\x82\xAC\xE2\x82\xAC', // 11100010 10000010 10101100 10000010 10101100 11100010 10000010 10101100
{strict: false},
) === '\u20AC\uFFFD\u20AC'; |
Closes #2 and #5