Improve app responsiveness while PID tuning

(cherry picked from commit 375c93c0075527207b78acce4d46d440c799ce94)
mathieucarbou · Jul 15, 2024 · ed9ab0f · ed9ab0f
1 parent 2cba0c2
commit ed9ab0f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/src/tasks/Dashboard.cpp b/src/tasks/Dashboard.cpp
@@ -8,7 +8,5 @@
 Mycila::Task dashboardTask("Dashboard", [](void* params) {
   YaSolR::Website.updateCards();
   YaSolR::Website.updateCharts();
-  if (!routingTask.isEnabled() || !config.getBool(KEY_ENABLE_PID_VIEW)) {
-    dashboard.sendUpdates();
-  }
+  dashboard.sendUpdates();
 });
diff --git a/src/tasks/Router.cpp b/src/tasks/Router.cpp
@@ -40,10 +40,7 @@ Mycila::Task routingTask("Routing", [](void* params) {
   router.divert(gridMetrics.voltage, gridMetrics.power);
 
   if (config.getBool(KEY_ENABLE_PID_VIEW)) {
-    // Dashboard
     YaSolR::Website.updatePID();
-    dashboard.sendUpdates();
-    // WebSocket
     AsyncWebSocketMessageBuffer* buffer = wsDebugPID.makeBuffer(256);
     snprintf((char*)buffer->get(), 256, "%d,%d,%d,%d,%d,%.3f,%.3f,%.3f,%d,%d,%.3f,%.3f,%.3f,%.3f,%.3f,%.3f,%.3f", pidController.getProportionalMode(), pidController.getDerivativeMode(), pidController.getIntegralCorrectionMode(), pidController.isReversed(), static_cast<int>(pidController.getSetPoint()), pidController.getKp(), pidController.getKi(), pidController.getKd(), static_cast<int>(pidController.getOutputMin()), static_cast<int>(pidController.getOutputMax()), pidController.getInput(), pidController.getOutput(), pidController.getError(), pidController.getSum(), pidController.getPTerm(), pidController.getITerm(), pidController.getDTerm()); // NOLINT
     wsDebugPID.textAll(buffer);