fix: match release_branches defaults exactly instead of matching as substrings#220
Open
cawfeecake wants to merge 1 commit intomathieudutour:masterfrom
Open
fix: match release_branches defaults exactly instead of matching as substrings#220cawfeecake wants to merge 1 commit intomathieudutour:masterfrom
release_branches defaults exactly instead of matching as substrings#220cawfeecake wants to merge 1 commit intomathieudutour:masterfrom
Conversation
cawfeecake
changed the title
release_branch defaults as substrings rather than exactrelease_branches defaults exactly instead of matching as substrings
cawfeecake
changed the title
release_branches defaults exactly instead of matching as substringsrelease_branches defaults exactly instead of matching as substrings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If a repo has a branch with a name that includes a substring of one of the defaults values of
release_branches, e.g.maintenance, this action will determine it to be a release branch when it should only be matching exactmainormaster.Fix
Prefix
^and suffix$makes matches exact. Also aligneddescription:with what is in README