Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/dockview-angular/src/lib/dockview-angular.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,13 @@ import { PaneviewAngularComponent } from './paneview/paneview-angular.component'
import { SplitviewAngularComponent } from './splitview/splitview-angular.component';

@NgModule({
declarations: [
imports: [
CommonModule,
DockviewAngularComponent,
GridviewAngularComponent,
PaneviewAngularComponent,
SplitviewAngularComponent
],
imports: [
CommonModule
],
exports: [
DockviewAngularComponent,
GridviewAngularComponent,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,15 @@ export interface DockviewAngularOptions extends DockviewOptions {

@Component({
selector: 'dv-dockview',
standalone: true,
template: '<div #dockviewContainer class="dockview-container"></div>',
styles: [`
:host {
display: block;
width: 100%;
height: 100%;
}

.dockview-container {
width: 100%;
height: 100%;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,15 @@ export interface GridviewAngularOptions extends GridviewOptions {

@Component({
selector: 'dv-gridview',
standalone: true,
template: '<div #gridviewContainer class="gridview-container"></div>',
styles: [`
:host {
display: block;
width: 100%;
height: 100%;
}

.gridview-container {
width: 100%;
height: 100%;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,15 @@ export interface PaneviewAngularOptions extends PaneviewOptions {

@Component({
selector: 'dv-paneview',
standalone: true,
template: '<div #paneviewContainer class="paneview-container"></div>',
styles: [`
:host {
display: block;
width: 100%;
height: 100%;
}

.paneview-container {
width: 100%;
height: 100%;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,15 @@ export interface SplitviewAngularOptions extends SplitviewOptions {

@Component({
selector: 'dv-splitview',
standalone: true,
template: '<div #splitviewContainer class="splitview-container"></div>',
styles: [`
:host {
display: block;
width: 100%;
height: 100%;
}

.splitview-container {
width: 100%;
height: 100%;
Expand Down
13 changes: 10 additions & 3 deletions packages/dockview-angular/src/lib/utils/angular-renderer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,19 @@ export class AngularRenderer implements IContentRenderer, IFrameworkPart {
}

init(parameters: Parameters): void {
this.render(parameters);
// If already initialized, just update the parameters
if (this.componentRef) {
this.update(parameters);
} else {
this.render(parameters);
}
}

update(params: Parameters): void {
if (this.componentRef) {
Object.keys(params).forEach(key => {
if (this.componentRef!.instance.hasOwnProperty(key)) {
// Use 'in' operator instead of hasOwnProperty to support getter/setter properties
if (key in this.componentRef!.instance) {
this.componentRef!.instance[key] = params[key];
}
});
Expand All @@ -62,7 +68,8 @@ export class AngularRenderer implements IContentRenderer, IFrameworkPart {

// Set initial parameters
Object.keys(parameters).forEach(key => {
if (this.componentRef!.instance.hasOwnProperty(key)) {
// Use 'in' operator instead of hasOwnProperty to support getter/setter properties
if (key in this.componentRef!.instance) {
this.componentRef!.instance[key] = parameters[key];
}
});
Expand Down
3 changes: 2 additions & 1 deletion packages/dockview-angular/src/lib/utils/component-factory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,8 @@ export class AngularFrameworkComponentFactory {
injector: this.injector,
environmentInjector: this.environmentInjector
});


// Initialize with empty props - dockview-core will call init() again with actual IGroupHeaderProps
renderer.init({});
return renderer;
}
Expand Down