DRY race::OnceRef::{get_or_try_init, set}.#286
Merged
matklad merged 2 commits intomatklad:masterfrom Mar 28, 2025
Merged
Conversation
Contributor
Author
|
I think this is the last one 😄. |
Owner
|
If it is last, lest bump patch in Cargo.toml! |
Centralize all the pointer type casting and RMW into a new `compare_exchange` function as was done in other types in the module. Leave the dereferencing of the pointer in `init()` as `set()` doesn't ever use the old value.
briansmith
force-pushed
the
b/once-ref-dry
branch
from
1ed6233 to
1ff0479
Compare
Contributor
Author
Done. |
Closed
briansmith
force-pushed
the
b/once-ref-dry
branch
from
1ff0479 to
a206950
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centralize all the pointer type casting and RMW into a new
compare_exchangefunction as was done in other types in the module. Leave the dereferencing of the pointer ininit()asset()doesn't ever use the old value.