Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect new brands: Leff, Tanix and Detect devices for existing brands: Lenovo, Huawei, Meizu, Chuwi, Vivax #6518

Merged
merged 17 commits into from
Dec 15, 2020
Merged

Detect new brands: Leff, Tanix and Detect devices for existing brands: Lenovo, Huawei, Meizu, Chuwi, Vivax #6518

merged 17 commits into from
Dec 15, 2020

Conversation

sanchezzzhak
Copy link
Collaborator

issue #6517

sanchezzzhak and others added 10 commits December 6, 2020 23:20
@sanchezzzhak
update README.md
47a267a
@sanchezzzhak
Merge pull request #7 from sanchezzzhak/updatereadme
a7cb380 
Update README.md
@sanchezzzhak
Merge remote-tracking branch 'upstream/master'
14a7cc3 
# Conflicts:
#	README.md
@sanchezzzhak
Merge remote-tracking branch 'upstream/master'
0c2958f
@sanchezzzhak
Merge remote-tracking branch 'upstream/master'
99bfb28
@sanchezzzhak
fix(device) detect common model for brand Huawei
31af682 
issue matomo-org#6517
@sanchezzzhak
feat(device) detect brand Huawei model: MediaPad T 10
d8c674b 
feat(device) detect brand Lenovo models: Tab M10 FHD Plus (TB-X606F), TAB4 8 (TB-8504X),
 Tab E7 (TB-7104I), TAB3 10 Plus (TB3-X70L), TAB3 8 Plus (TB-8703X), TAB2 A10 (A10-70L)

issue matomo-org#6517
@sanchezzzhak
feat(device) detect brand Lenovo models: Tab M10 FHD Plus (TB-X606X),…
eeae05d 
… TAB 2 A7 (A7-30HC, A7-30GC),

 TAB4 8 Plus (TB-8704X), Tab 7 Essential (TB-7304X), Tab 7 (TB-7504X)
feat(device) detect brand Meizu model: 15 Lite

issue matomo-org#6517
@sanchezzzhak
feat(device) detect new brand BOE model: HV320WHB-N55
e642523 
feat(device) detect brand Rombica model: Smart Box v009

issue matomo-org#6517
@sanchezzzhak
feat(device) rename new brand BOE to Leff model: HV320WHB-N55
806b1a5 
issue matomo-org#6517
sanchezzzhak and others added 3 commits December 9, 2020 23:57
@sanchezzzhak
fix: tests
1cbcf50
@sanchezzzhak
feat(device) detect brand Huawei model: Honor Pad V6 (KRJ-W09)
636c2fa 
feat(device) detect brand Lenovo models: TAB3 7 Plus (TB-7703X), M10 (TB-X505X), Tab M8 (TB-8505F)

issue matomo-org#6517
@sanchezzzhak
feat(device) detect brand Lenovo model: TAB 2 A7 (A7-30DC)
6d6e6c4 
feat(device) detect brand Chuwi model: Hi9 Air
feat(device) rename model Lenovo Tab 4 10 Plus => Lenovo TAB4 10 Plus

issue matomo-org#6517
@sanchezzzhak sanchezzzhak changed the title Detect new brands: Leff and Detect devices for existing brands: Lenovo, Huawei, Meizu Detect new brands: Leff and Detect devices for existing brands: Lenovo, Huawei, Meizu, Chuwi Dec 10, 2020
@sanchezzzhak
Copy link
Collaborator Author

@sgiehl

This definition bothers me.

Leff Shell HV320WHB-N55
Shell Prefix-means that the mainboard or panel number goes next
HV320WHB-N55 - Mainboard ID from the manufacturer BOE
image
https://tvscreen.en.made-in-china.com/product/AOynpreJJUhW/China-Good-TV-Panel-Module-HD-32-Inch-TV-Open-Cell-Hv320whb-N55.html
a similar mainboard is used in the brand Manta model 32lha19s, Digma DM-LED32R301BT2S etc

Leave the model empty?

@sgiehl
Copy link
Member

sgiehl commented Dec 10, 2020

@sanchezzzhak
If it doesn't point to an explicit device model, guess it makes sense to leave it empty.
Or if it is never possible for that brand maybe some generic model like Generic Smart TV or similar might make sense

@sanchezzzhak
fix brand Leff
ec681b8
@sanchezzzhak
feat(device) detect new brand Tanix model: TX5 Max
0479b2a 
feat(device) detect brand Lenovo model: Yoga Tab 3 Plus (YT-X703L)
feat(device) detect brand Vivax model: Fly V1

issue matomo-org#6517
@sanchezzzhak
feat(test) added test for brand Tanix model: TX5 Max
7eaaa08 
issue matomo-org#6517
@sanchezzzhak sanchezzzhak changed the title Detect new brands: Leff and Detect devices for existing brands: Lenovo, Huawei, Meizu, Chuwi Detect new brands: Leff, Tanix and Detect devices for existing brands: Lenovo, Huawei, Meizu, Chuwi, Vivax Dec 11, 2020
@sgiehl sgiehl merged commit 6eb9138 into matomo-org:master Dec 15, 2020
@sanchezzzhak sanchezzzhak deleted the 6517 branch December 15, 2020 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees

@sgiehl sgiehl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sanchezzzhak @sgiehl