Skip to content

Commit

Permalink
Ensure grouping a dimension in ms doesn't fail if ranking query limit…
Browse files Browse the repository at this point in the history
… is reached
  • Loading branch information
sgiehl committed Sep 12, 2024
1 parent df6aa0b commit 1519acb
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions core/Columns/Dimension.php
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,10 @@ public function groupValue($value, $idSite)
case Dimension::TYPE_BOOL:
return !empty($value) ? '1' : '0';
case Dimension::TYPE_DURATION_MS:
if (!is_numeric($value)) {
// This might happen if ranking query has too many results and `__mtm_ranking_query_others__` is returned
return $value;
}
return round($value / 1000, 2) * 1000; // because we divide we need to group them and cannot do this in formatting step
}
return $value;
Expand Down

0 comments on commit 1519acb

Please sign in to comment.