Skip to content

Commit

Permalink
run invalidation test in multiple timezones
Browse files Browse the repository at this point in the history
  • Loading branch information
sgiehl committed Jul 9, 2024
1 parent e3d3c7e commit 23f7dc5
Show file tree
Hide file tree
Showing 2 changed files with 100 additions and 67 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,9 @@
namespace Piwik\Plugins\CoreAdminHome\tests\Integration\Commands;

use Monolog\Handler\AbstractProcessingHandler;
use Piwik\Config;
use Piwik\Container\StaticContainer;
use Piwik\CronArchive;
use Piwik\Date;
use Piwik\Plugins\CoreAdminHome\API as CoreAdminHomeAPI;
use Piwik\Plugins\CustomDimensions\CustomDimensions;
use Piwik\Plugins\CustomDimensions\API as CustomDimensionsAPI;
use Piwik\Plugins\PrivacyManager\Model\DataSubjects;
use Piwik\Plugins\SegmentEditor\API as SegmentEditorAPI;
use Piwik\Plugins\VisitFrequency\API as VisitFrequencyAPI;
use Piwik\Plugins\VisitsSummary\API as VisitsSummaryAPI;
use Piwik\Tests\Framework\Fixture;
use Piwik\Tests\Framework\TestCase\ConsoleCommandTestCase;

Expand Down Expand Up @@ -505,65 +497,6 @@ public function getTestDataForSuccessTests(): iterable
];
}

public function testInvalidationOfDependentSegments()
{
$testDate = Date::today()->subDay(10)->toString();

// disable browser archiving
Config::getInstance()->General['enable_browser_archiving_triggering'] = 0;
Config::getInstance()->General['browser_archiving_disabled_enforce'] = 1;

SegmentEditorAPI::getInstance()->add('fr segment', 'languageCode==fr', 1, true);

// track a visitor
$t = Fixture::getTracker(1, $testDate . ' 12:00:00', true);
$t->setUserAgent('Mozilla/5.0 (compatible; MSIE 10.0; Windows Vista; Trident/5.0');
$t->setIp('10.11.12.13');
$t->setUrl('http://piwik.net/randomsite');
$t->doTrackPageView('random site');

// With a returning visit
$t->setForceVisitDateTime($testDate . ' 17:00:00');
$t->setForceNewVisit();
$t->doTrackPageView('random site');

// track a second visitor
$t = Fixture::getTracker(1, $testDate . ' 12:30:00', true);
$t->setIp('20.21.22.23');
$t->setUserAgent('Mozilla/5.0 (compatible; MSIE 10.0; Windows 8; Trident/5.0)');
$t->setUrl('http://piwik.net/randomsite');
$t->doTrackPageView('random site');

$archiver = new CronArchive();
$archiver->main();

$result = VisitsSummaryAPI::getInstance()->get(1, 'week', $testDate, 'languageCode==fr');
self::assertEquals(3, $result->getFirstRow()->getColumn('nb_visits'));

$result = VisitFrequencyAPI::getInstance()->get(1, 'week', $testDate, 'languageCode==fr');
self::assertEquals(1, $result->getFirstRow()->getColumn('nb_visits_returning'));
self::assertEquals(2, $result->getFirstRow()->getColumn('nb_visits_new'));

// Remove one visit
$datasubject = StaticContainer::get(DataSubjects::class);
$datasubject->deleteDataSubjectsWithoutInvalidatingArchives([['idvisit' => '1']]);

// Invalidate the segment
CoreAdminHomeAPI::getInstance()->invalidateArchivedReports('1', $testDate, 'day', 'languageCode==fr');

// re-run archiving
$archiver = new CronArchive();
$archiver->main();

$result = VisitsSummaryAPI::getInstance()->get(1, 'week', $testDate, 'languageCode==fr');
self::assertEquals(2, $result->getFirstRow()->getColumn('nb_visits'));

// check that metrics built with dependent segment archives are updated as well
$result = VisitFrequencyAPI::getInstance()->get(1, 'week', $testDate, 'languageCode==fr');
self::assertEquals(1, $result->getFirstRow()->getColumn('nb_visits_returning'));
self::assertEquals(1, $result->getFirstRow()->getColumn('nb_visits_new'));
}

/**
* @return array<string, mixed>
*/
Expand Down
100 changes: 100 additions & 0 deletions plugins/CoreAdminHome/tests/Integration/InvalidateReportDataTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,100 @@
<?php

/**
* Matomo - free/libre analytics platform
*
* @link https://matomo.org
* @license https://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later
*/

namespace Piwik\Plugins\CoreAdminHome\tests\Integration;

use Piwik\Config;
use Piwik\Container\StaticContainer;
use Piwik\CronArchive;
use Piwik\Date;
use Piwik\Plugins\CoreAdminHome\API as CoreAdminHomeAPI;
use Piwik\Plugins\PrivacyManager\Model\DataSubjects;
use Piwik\Plugins\SegmentEditor\API as SegmentEditorAPI;
use Piwik\Plugins\VisitFrequency\API as VisitFrequencyAPI;
use Piwik\Plugins\VisitsSummary\API as VisitsSummaryAPI;
use Piwik\Tests\Framework\Fixture;
use Piwik\Tests\Framework\TestCase\IntegrationTestCase;

/**
* @group CoreAdminHome
* @group CoreAdminHome_Integration
*/
class InvalidateReportDataTest extends IntegrationTestCase
{
/**
* @dataProvider getTimezones
*/
public function testInvalidationOfDependentSegments($timezone)
{
Fixture::createSuperUser(true);
$idSite = Fixture::createWebsite('2024-01-01 00:00:00', 0, false, false, 1, null, null, $timezone);

$testDate = Date::today()->subDay(10);
$timezoneTestDate = $testDate->subSeconds(Date::getUtcOffset($timezone));

// disable browser archiving
Config::getInstance()->General['enable_browser_archiving_triggering'] = 0;
Config::getInstance()->General['browser_archiving_disabled_enforce'] = 1;

SegmentEditorAPI::getInstance()->add('fr segment', 'languageCode==fr', $idSite, true);

// track a visitor
$t = Fixture::getTracker($idSite, $timezoneTestDate->addHour(12)->getDatetime(), true);
$t->setUserAgent('Mozilla/5.0 (compatible; MSIE 10.0; Windows Vista; Trident/5.0');
$t->setIp('10.11.12.13');
$t->setUrl('http://piwik.net/randomsite');
$t->doTrackPageView('random site');

// With a returning visit
$t->setForceVisitDateTime($timezoneTestDate->addHour(17)->getDatetime());
$t->setForceNewVisit();
$t->doTrackPageView('random site');

// track a second visitor
$t = Fixture::getTracker($idSite, $timezoneTestDate->addHour(12.5)->getDatetime(), true);
$t->setIp('20.21.22.23');
$t->setUserAgent('Mozilla/5.0 (compatible; MSIE 10.0; Windows 8; Trident/5.0)');
$t->setUrl('http://piwik.net/randomsite');
$t->doTrackPageView('random site');

$archiver = new CronArchive();
$archiver->main();

$result = VisitsSummaryAPI::getInstance()->get($idSite, 'week', $testDate->toString(), 'languageCode==fr');
self::assertEquals(3, $result->getFirstRow()->getColumn('nb_visits'));

$result = VisitFrequencyAPI::getInstance()->get($idSite, 'week', $testDate->toString(), 'languageCode==fr');
self::assertEquals(1, $result->getFirstRow()->getColumn('nb_visits_returning'));
self::assertEquals(2, $result->getFirstRow()->getColumn('nb_visits_new'));

// Remove one visit
$datasubject = StaticContainer::get(DataSubjects::class);
$datasubject->deleteDataSubjectsWithoutInvalidatingArchives([['idvisit' => 1]]);

// Invalidate the segment
CoreAdminHomeAPI::getInstance()->invalidateArchivedReports($idSite, $testDate->toString(), 'day', 'languageCode==fr');

// re-run archiving
$archiver = new CronArchive();
$archiver->main();

$result = VisitsSummaryAPI::getInstance()->get($idSite, 'week', $testDate->toString(), 'languageCode==fr');
self::assertEquals(2, $result->getFirstRow()->getColumn('nb_visits'));

// check that metrics built with dependent segment archives are updated as well
$result = VisitFrequencyAPI::getInstance()->get($idSite, 'week', $testDate->toString(), 'languageCode==fr');
self::assertEquals(1, $result->getFirstRow()->getColumn('nb_visits_returning'));
self::assertEquals(1, $result->getFirstRow()->getColumn('nb_visits_new'));
}

public function getTimezones()
{
return [['UTC-12'], ['UTC'], ['UTC+14']];
}
}

0 comments on commit 23f7dc5

Please sign in to comment.