Skip to content

Commit

Permalink
Fix quirky behaviour of height adjustment when using kartograph libra…
Browse files Browse the repository at this point in the history
…ry, causing 2px shift in map height (#22267)

* Remove extra resizing causing bump in height

* Temp reduce test suite

* Set container heigh to same as map

* Update screenshots for test

* Revert "Temp reduce test suite"

This reverts commit 5d16010.

* Update screenshots for tests affected by change

* Add the -2 back and change order

* Revert "Add the -2 back and change order"

This reverts commit 79f4bd1.
  • Loading branch information
caddoo authored Jun 3, 2024
1 parent 1f69c5c commit 6527fa0
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 13 deletions.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion plugins/UserCountryMap/javascripts/visitor-map.js
Original file line number Diff line number Diff line change
Expand Up @@ -1359,7 +1359,7 @@
h = Math.min(maxHeight, h);
}

map.container.height(h - 2);
map.container.height(h);
map.resize(w, h);

if (w < 355) $('.UserCountryMap .tableIcon span').hide();
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions tests/UI/expected-screenshots/Menus_mobile_left.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 6527fa0

Please sign in to comment.